Skip to content

Conversation

@dims
Copy link
Contributor

@dims dims commented Sep 4, 2025

https://github.com/yaml/go-yaml/tree/v2/ is a supported version of what was previously in gopkg.in/yaml.v2

the older repo has this notice

This repository was archived by the owner on Apr 1, 2025. It is now read-only.

Many repositories including kubernetes moved to the newer supported versions, some context from kubernetes is here:
kubernetes/kubernetes#132056

@dims
Copy link
Contributor Author

dims commented Sep 4, 2025

cc @aknuds1

Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@dims dims force-pushed the move-to-supported-version-of-yaml-parser branch from bcbcd9c to 5cf3d41 Compare September 4, 2025 15:09
Copy link
Contributor

@aknuds1 aknuds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'd still like to hear from @bwplotka though or maybe @ywwg, as to whether this would have any implications wrt. dependents on prometheus/common, e.g. prometheus/prometheus.

@SuperQ
Copy link
Member

SuperQ commented Sep 4, 2025

Related: prometheus/proposals#49

Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The v2 migration should be 1:1 drop-in.

We'll probably want to plan upgrading the Prometheus ecosystem to the v4 version eventually

@aknuds1 aknuds1 requested review from bwplotka and ywwg September 4, 2025 15:47
@aknuds1 aknuds1 merged commit 08d7f66 into prometheus:main Sep 4, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants