Enable revive rule unused-parameter #824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables the unused-parameter revive linting rule by removing its disabled status from the configuration and fixing all instances where function parameters were unused by replacing them with the blank identifier _.
Key Changes:
- Enabled the
unused-parameterrevive rule in.golangci.yml - Replaced unused parameter names with
_across multiple test files and implementation files - Updated interface method implementations to use blank identifiers for unused parameters
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
.golangci.yml |
Removed the disabled status for the unused-parameter revive rule |
server/static_file_server_test.go |
Replaced unused path parameter with _ in Open method |
route/route_test.go |
Replaced unused http.ResponseWriter parameters with _ in test handler functions |
promslog/slog.go |
Replaced unused groups parameter with _ in replace attribute function |
expfmt/text_parse_test.go |
Replaced unused p []byte parameter with _ in Read method |
expfmt/decode.go |
Replaced unused v *dto.MetricFamily parameter with _ in Decode method |
config/http_config_test.go |
Replaced unused parameters with _ in test handler functions and mock implementations |
config/http_config.go |
Replaced unused ctx context.Context parameter with _ in Fetch method |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
SuperQ
approved these changes
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable revive rule
unused-parameterand fix issues.