Enable unconvert linter #819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request enables the unconvert linter in the project and fixes all the unnecessary type conversions it identified. The unconvert linter detects type conversions that are redundant because the expression is already of the target type.
- Enables the
unconvertlinter in the golangci-lint configuration - Removes unnecessary type conversions across multiple Go files
- Fixes redundant string conversions and type casts
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .golangci.yml | Uncomments the unconvert linter to enable it |
| model/value.go | Removes unnecessary string conversion in JSON marshaling |
| model/time.go | Removes redundant string conversions in time parsing |
| model/metric_test.go | Removes unnecessary string conversion in regex matching |
| config/http_config.go | Removes multiple unnecessary type conversions in configuration validation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ywwg
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable unconvert linter and fix issues.