Enable gocritic linter #818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables the gocritic linter by uncommenting it in the .golangci.yml configuration file and fixes various code style issues identified by the linter.
- Enables the
gocriticlinter in the configuration - Replaces if-else chains with switch statements for better readability
- Simplifies assignments and removes unnecessary operations
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .golangci.yml | Uncomments the gocritic linter to enable it |
| model/value.go | Replaces if-else chain with switch statement in MarshalJSON |
| model/time.go | Simplifies string concatenation assignment |
| model/metric.go | Converts multiple if-else chains to switch statements |
| expfmt/text_parse.go | Replaces if-else chain with switch statement |
| expfmt/openmetrics_create.go | Simplifies assignment and removes unnecessary pointer dereference |
| config/http_config_test.go | Converts if-else chain to switch statement |
| config/http_config.go | Removes unnecessary slice operations on byte arrays |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ywwg
approved these changes
Aug 26, 2025
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable the
gocriticlinter, and fix issues.