docs: fix typo in expfmt.Negotiate #813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wil Cram <wcram@wisc.edu>
ywwg
approved these changes
Aug 13, 2025
Member
ywwg
left a comment
There was a problem hiding this comment.
noop lgtm. I don't know if we have a CLA that needs to be signed?
Contributor
Author
|
Since the project is Apache licensed and this pr adds no new functionality, it looks like we should be fine. |
ArthurSens
approved these changes
Aug 13, 2025
Member
We have DCO checks, that should be enough :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Negotiatefunction in theexpfmtpackage was referencing a functionNegotiateOpenMetricswhich probably should beNegotiateIncludingOpenMetrics. I also noticed that the test referencing this function had the same issue; this commit makes the naming consistent everywhere.Signed-off-by: Wil Cram wcram@wisc.edu