http_config: Allow customizing TLS config and settings.#748
Merged
Conversation
Signed-off-by: bwplotka <bwplotka@gmail.com>
8a0f010 to
ca379f3
Compare
machine424
reviewed
Jan 16, 2025
Signed-off-by: bwplotka <bwplotka@gmail.com>
a9b7f13 to
072259e
Compare
machine424
reviewed
Jan 16, 2025
machine424
reviewed
Jan 16, 2025
Signed-off-by: bwplotka <bwplotka@gmail.com>
6e6edac to
7ece29f
Compare
machine424
approved these changes
Jan 16, 2025
Member
machine424
left a comment
There was a problem hiding this comment.
lgtm, thanks.
(ok to change the default from NewTLSConfig to NewTLSConfigWithContext)
SuperQ
approved these changes
Jan 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We (Google) would love to modify TLS config for custom authorization settings for our environments. Sometimes it means literally using our internal Go tls.Config instead of the created one by this client. This PR adds a minimal change to support a single option to do that, hope that makes sense!