Remove deprecated ioutil#410
Closed
lucacome wants to merge 1 commit intoprometheus:mainfrom
lucacome:fix-ioutil
Closed
Remove deprecated ioutil#410lucacome wants to merge 1 commit intoprometheus:mainfrom lucacome:fix-ioutil
lucacome wants to merge 1 commit intoprometheus:mainfrom
lucacome:fix-ioutil
Conversation
Signed-off-by: Luca Comellini <luca.com@gmail.com>
This was referenced Nov 11, 2022
Contributor
|
This can be closed now, #407 was merged. Right? |
Contributor
Author
|
yep, closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#345 added some code that uses
ioutilwithout adding the import and the tests are failing.ioutilis deprecated anyway, so I just replaced the calls withioandos.(Sorry about the formatting changes)