Closed
Conversation
…togram Signed-off-by: Vitaly Lavrov <lavrovvv@gmail.com>
060ea36 to
82f652c
Compare
Contributor
brian-brazil
left a comment
There was a problem hiding this comment.
There's several unrelated changes in here, please keep the diff minimal with such a large change.
benchmark/src/main/java/io/prometheus/benchmark/SummaryBenchmark.java
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Live 72 needs updating.
Contributor
There was a problem hiding this comment.
What if someone has multiple different error values?
simpleclient_common/src/test/java/io/prometheus/client/exporter/common/TextFormatTest.java
Outdated
Show resolved
Hide resolved
simpleclient/src/test/java/io/prometheus/client/SummaryTest.java
Outdated
Show resolved
Hide resolved
simpleclient/src/main/java/io/prometheus/client/TimeWindowQuantiles.java
Outdated
Show resolved
Hide resolved
simpleclient/src/main/java/io/prometheus/client/TimeWindowQuantiles.java
Outdated
Show resolved
Hide resolved
c7360c1 to
5b86037
Compare
Signed-off-by: Vitaly Lavrov <lavrovvv@gmail.com>
5b86037 to
b7b696a
Compare
Signed-off-by: Vitaly Lavrov <lavrovvv@gmail.com>
19c321a to
2592f88
Compare
Signed-off-by: Vitaly Lavrov <lavrovvv@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This work supersedes #484. The main difference is that HdrHistogram implementation is copy-pasted as is to remove external dependency.