Merged
Conversation
Member
|
If you don't mind I will change it to point to the release branch as it's a critical fix. Do you mind bumping patch version and CHANGELOG too? Checking what we can do for testability. |
bwplotka
reviewed
Aug 20, 2024
bwplotka
approved these changes
Aug 20, 2024
Member
There was a problem hiding this comment.
Cool, let's rebase, merge and release 1.20.1 (do you mind changing version and changelog too?).
Validating all cases for avoiding those regressions are discussed here: #1591, but just changing to pedantic registry would catch this (see my CI test run): https://github.com/prometheus/client_golang/actions/runs/10469430197/job/28992461341?pr=1592#step:3:1339
Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
Signed-off-by: bwplotka <bwplotka@gmail.com>
Signed-off-by: bwplotka <bwplotka@gmail.com>
3224f59 to
4a15d05
Compare
Member
Author
|
Thanks for finishing this up! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix #1584
Thanks @bwplotka for investigating and finding the problem.