Fix broken docker build.sh and circleci pipeline issues#67
Merged
SuperQ merged 1 commit intoprometheus:masterfrom Dec 2, 2025
Merged
Fix broken docker build.sh and circleci pipeline issues#67SuperQ merged 1 commit intoprometheus:masterfrom
SuperQ merged 1 commit intoprometheus:masterfrom
Conversation
Signed-off-by: Max Huebler <max@huebler.us>
Contributor
Author
|
@SuperQ did you want strictly the fix for the failing builds or should I include .circleci/config.yml changes such as updating vm machine ubuntu image? |
SuperQ
approved these changes
Dec 2, 2025
Member
SuperQ
left a comment
There was a problem hiding this comment.
Thanks. It's easier to review this way.
Yes, let's follow up with other improvements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@SuperQ
Description
This PR fixes modernizes the build system to use Docker's
--platformflag for better cross-compilation support and fixes CI build failures. This originally was included as part of #66.Changes
vars.shandbuild.shto use the standard Docker--platformflag (e.g.,linux/arm/v7) instead of deprecated architecture-prefixed images (e.g.,arm32v7/debian).no match for platform in manifesterrors encountered during cross-compilation.Motivation
The build system updates were necessary to fix broken cross-compilation on modern Docker environments.