Skip to content

config: add MarshalSecrets flag#2316

Closed
bobheadxi wants to merge 1 commit into
prometheus:masterfrom
bobheadxi:master
Closed

config: add MarshalSecrets flag#2316
bobheadxi wants to merge 1 commit into
prometheus:masterfrom
bobheadxi:master

Conversation

@bobheadxi

Copy link
Copy Markdown

closes #1985

we're trying to update Alertmanager configuration programatically (rather than by hand). The config package structs make this a lot easier, but unfortunately it is impossible to write updated configuration back to disk for Alertmanager to reload and use since secrets get replaced. Adding something like config.MarshalSecrets would allow anyone using the config package directly to write secrets when needed

Signed-off-by: Robert Lin <robert@bobheadxi.dev>
@bobheadxi bobheadxi changed the title config: add MarshalSecret flag config: add MarshalSecrets flag Jul 2, 2020
@francisminu

Copy link
Copy Markdown

Does that mean, at some point we might be able to pass a config to the POST reload method rather than being loaded from what is there on the disk?
-Thanks!

@roidelapluie roidelapluie left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The config package is an internal package that is not meant to be used externally.

@bobheadxi bobheadxi closed this Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: override secret censoring during marshaling to YAML

3 participants