Skip to content

docs(DCP-2585): add CONTRIBUTING.md and update cross-references#373

Merged
script-this merged 2 commits intomainfrom
dcp-2585-add-contributing-md
Mar 20, 2026
Merged

docs(DCP-2585): add CONTRIBUTING.md and update cross-references#373
script-this merged 2 commits intomainfrom
dcp-2585-add-contributing-md

Conversation

@script-this
Copy link
Copy Markdown
Contributor

Summary

Adds a comprehensive CONTRIBUTING.md to the Prolific CLI, welcoming external contributors and setting expectations for the contribution process. Links to DEVELOPMENT.md for detailed development guidance rather than duplicating content.

CONTRIBUTING.md

Covers:

  • Code of Conduct expectations (formal Contributor Covenant adoption planned)
  • Ways to contribute (code, docs, bugs, features, triage) with mentorship for first-timers
  • Questions via GitHub Discussions, Issues for bugs/features
  • Bug reporting and feature request guidance
  • First contribution walkthrough with troubleshooting tips
  • Development quickstart linking to DEVELOPMENT.md for full details
  • Pull request process, commit message format, and code review expectations (~1 week turnaround)
  • Recognition, licensing (Apache 2.0)

Issue templates and PR template are noted as coming soon — will be added in a follow-up to ensure they work well for both external contributors and internal staff.

Cross-references

  • README.md — added "Contributing" section linking to CONTRIBUTING.md
  • DEVELOPMENT.md — added callout directing new contributors to CONTRIBUTING.md
  • AGENTS.md — added CONTRIBUTING.md to related documentation links

@prolific-snyk
Copy link
Copy Markdown

prolific-snyk commented Mar 20, 2026

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@script-this script-this force-pushed the dcp-2585-add-contributing-md branch from 4312758 to 945475f Compare March 20, 2026 10:54
@script-this script-this force-pushed the dcp-2585-add-contributing-md branch from 1f1f2e7 to f89881e Compare March 20, 2026 10:56
@script-this script-this marked this pull request as ready for review March 20, 2026 10:59
@script-this script-this requested a review from a team as a code owner March 20, 2026 10:59
@script-this script-this added team-dct dct-ready-for-review Triggers Slack notification when PR is ready for review labels Mar 20, 2026
CONTRIBUTING.md Outdated
Comment on lines +40 to +44
Use [GitHub Discussions](https://github.com/prolific-oss/cli/discussions) for questions, ideas, and general conversation. Keep [Issues](https://github.com/prolific-oss/cli/issues) for bug reports and feature requests.

## Discuss Before You Code

For non-trivial changes, please open an issue first to discuss your approach. This avoids wasted effort if the change doesn't align with the project's direction or if someone else is already working on it. Small fixes (typos, one-line bug fixes) can go straight to a PR.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We say discussions for general convo but then say to open an issue to discuss changes. Might be just a wording thing here. If I have a non-trivial change should I:

  • start a discussion first to ensure it aligns with the project
  • OR create an issue and mark as a feature request


## Reporting Bugs

[Open an issue](https://github.com/prolific-oss/cli/issues/new) to report bugs (issue templates coming soon). A good bug report includes:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One for later if we don't have it already but definitely nice to have an issue template for people to fill out

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good shout, toyed with adding that + PR + feature templates in this but I'll add follow ticket on to phase 3 / 4 CLI epic for it.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@script-this script-this merged commit b54555d into main Mar 20, 2026
5 checks passed
@script-this script-this deleted the dcp-2585-add-contributing-md branch March 20, 2026 18:27
@script-this script-this linked an issue Apr 2, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dct-ready-for-review Triggers Slack notification when PR is ready for review team-dct

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add CONTRIBUTING.md

3 participants