Merged
Conversation
There's currently a bug (pelletier/go-toml#450) in the toml library proji is using and its affecting our package export. In some cases the name field of a package is missing and sometimes its duplicate. The problem is backtrackable to the order command which makes it so packages exports always look the same and in their intended order. Until the fix is out we'll just take out the order command. Export works fine; just isn't ordered anymore as originally wanted.
Package editing has just become much simpler. Instead of the old and cumbersome way (as described in issue #137) there is now the 'edit' command which will export the chosen packages config to a temporary file, open that file in your systems prefered graphical text editor, wait for you to edit and save the config file and replace the old package with the freshly edited one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve editing of proji packages. Instead of exporting, editing, removing an importing the edited config, you now only have to execute the
editcommand and the os will open the packages config file in the default editor. After editing you only need to confirm your edits to proji by pressing the 'Enter' key and you're done.Example commands:
proji package edit <Package Name>or the short version
proji p e <Package Name>Proposed Changes
etoxeditcommand (short:e)Resolved Issues
Closes #137