Conversation
Proji will now load and execute lua scripts (internally called plugins) instead of shell scripts. Lua scripts have the advantage that they run cross-platform; where as the shell scripts do not. Someone who created his powershell script on windows would have had difficulties sharing it with someone on linux or mac. Lua solves that problem and introduces a single truth when it comes to proji scripts. Closes #119
Until now project.Create received a string which held the path of the current working directory. That was done to reduce overhead when creating multiple projects in the same runtime. The problem is that the function signature looked really confusing. Why do I have to pass my current working directory to the project.Create function. The parameter got removed and the function call itself reads in the cwd. So basically readability > performance in that case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Drop support for shell scripts and add support for lua scripts. Lua scripts are runnable cross-platform, which makes it superior over shell scripts in our use case.
Proposed Changes
Closes #119