Conversation
Extract all config related code from cmd/root and move it into the config package. Refactor the config package too. It's now more idiomatic and easier to read and use.
deploy now manages the creation of the main config folder and file. It is called from cmd/init and initializes the main config folder, if it does not exist. Additionally it now doesn't download the main config no more but rather creates a empty config instance, loads it default values and writes it to memory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completely refactor the config package. Make it simpler and more idiomatic.
Proposed Changes
cmdtoconfigpackage