(feat) add takeOwnership #1547
Merged
(feat) add takeOwnership #1547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR introduces the `TakeOwnership` field to both HelmInstallOptions and HelmUpgradeOptions. Currently, when Sveltos attempts to deploy a Helm chart, the operation may fail if resources defined in the chart already exist in the target cluster but lack the expected Helm ownership annotations (e.g., meta.helm.sh/release-name). This is standard Helm safety behavior. By enabling TakeOwnership, Sveltos will instruct the Helm engine to ignore these ownership checks and "adopt" the existing resources into the current release.
7916527 to
22b4f5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the
TakeOwnershipfield to both HelmInstallOptions and HelmUpgradeOptions.Currently, when Sveltos attempts to deploy a Helm chart, the operation may fail if resources defined in the chart already exist in the target cluster but lack the expected Helm ownership annotations (e.g., meta.helm.sh/release-name). This is standard Helm safety behavior.
By enabling TakeOwnership, Sveltos will instruct the Helm engine to ignore these ownership checks and "adopt" the existing resources into the current release.
Fixes #1546