Skip to content

fix off-by-one bug for hamster export tsv#577

Closed
GeraldJansen wants to merge 2 commits intoprojecthamster:masterfrom
GeraldJansen:off-by-one
Closed

fix off-by-one bug for hamster export tsv#577
GeraldJansen wants to merge 2 commits intoprojecthamster:masterfrom
GeraldJansen:off-by-one

Conversation

@GeraldJansen
Copy link
Contributor

This PR is a workaround for a bug concerning the range.end in some date ranges (#576).

A better fix would address the issue in hamster.lib.datetime.Range.from_start_end(), but my attempts there created other problems.

@GeraldJansen
Copy link
Contributor Author

@elbenfreund Hmm, I signed the CLA long ago. Now if I click on the CLA banner I get this message:

Error
There is no CLA to sign for projecthamster/hamster
(could not find linked item for owner projecthamster and repo hamster)

@projecthamster projecthamster deleted a comment from CLAassistant Mar 6, 2020
@elbenfreund
Copy link
Contributor

My appologies @GeraldJansen as explained here I triggered a project wide refresh when I started working on hamster-*. I disabled the CLA check for hamster and hamster-shell-extension. Please excuse the noise.

@GeraldJansen
Copy link
Contributor Author

Okay, the comment is gone, but I still see "Some checks haven't completed yet" and "license/cla pending".

@elbenfreund
Copy link
Contributor

Yes. As explained in this comment this will probably change once another push is triggered. Anyway, it is not a mandatory check, so it should not impose on anyone's work.

@elbenfreund
Copy link
Contributor

Looking good :)

@ederag
Copy link
Collaborator

ederag commented Mar 8, 2020

Good, there must never be a CLA on this repo.
At least my contributions are pure GPL.

I was curious about the origin of this bug, see #580.

@GeraldJansen
Copy link
Contributor Author

Closed in favour of better #580. Yay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants