Document current MSRV, note thoolchain, normalize metadata across workspace#348
Document current MSRV, note thoolchain, normalize metadata across workspace#348alerque merged 4 commits intoprojectfluent:mainfrom
Conversation
waywardmonkeys
left a comment
There was a problem hiding this comment.
A couple of questions, but also, I think this would be better as a single PR that starts to use the workspace info, and then something setting up rust-version. It isn’t clear to me why set edition via the workspace, but not license or other info that is the same.
|
Yes I'd be find with splitting this up ... or appending a few more things that can be normalized via workspace meta data. I was just feeling my way around what is currently here so I have a better understanding of what will/won't break when other adjustments are made (e.g. will bumping dependencies as in other PR's change the MSRV). But since I suggest not landing anything at all until we figure out a safe harbor release (which means access to crates.io etc.) I'll leave it together for now for discussion and if we want to refactor it later when we're ready to move on we can of course. I'm comfortable with Git rebase/revise/absorb etc. |
waywardmonkeys
left a comment
There was a problem hiding this comment.
Everything seems fine to me for the workspace meta data, but I don't think we need the rust-toolchain
We'll need to fix up CI separately to do something more similar to what the Linebender repos do in that regard.
This is the status quo not a change, only documented for tooling that recognizes this field. Also sets the edition in the workspace and inherits both edition and the MSRV (rust-version) field into all crates.
The MSRV information is the status quo not a change, only documented for tooling that recognizes this field.
Likewise the toolchain file is just for the aid of CI and developer tooling that happens to support it.