extending test coverage

Mzack9999 · Mzack9999 · commit aeb7bbbca1d2 · 2023-02-12T22:54:19.000+01:00
diff --git a/strings/stringsutil.go b/strings/stringsutil.go
@@ -246,10 +246,10 @@ func LongestRepeatingSequence(s string) LongestSequence {
 	return LongestSequence{Sequence: res, Count: resCount}
 }
 
-//Truncate a string to max length
+// Truncate a string to max length
 func Truncate(data string, maxSize int) string {
-	if maxSize > 0 && len(data) > maxSize {
+	if maxSize >= 0 && len(data) > maxSize {
 		return data[:maxSize]
 	}
 	return data
-}
+}
diff --git a/strings/stringsutil_test.go b/strings/stringsutil_test.go
@@ -289,23 +289,25 @@ func TestLongestRepeatingSequence(t *testing.T) {
 	}
 }
 
-
-type truncatetest struct{
-	MaxSize int
-	Result interface{}
+type truncaTeest struct {
+	test    string
+	maxSize int
+	result  string
 }
 
 func TestTruncate(t *testing.T) {
-	tests := map[string]truncatetest{
-		"abcd": 		  {MaxSize: 0, Result: "abcd"},
-		"abcde":          {MaxSize: 3, Result: "abc"},
-		"abcdef":         {MaxSize: 8, Result: "abcdef"},
-		"abcdefg":        {MaxSize: 6, Result: "abcdef"},
+	tests := []truncaTeest{
+		{test: "abcd", maxSize: -1, result: "abcd"},
+		{test: "abcd", maxSize: 0, result: ""},
+		{test: "abcde", maxSize: 3, result: "abc"},
+		{test: "abcdef", maxSize: 8, result: "abcdef"},
+		{test: "abcdefg", maxSize: 6, result: "abcdef"},
+		{test: "aaaa", maxSize: 20, result: "aaaa"},
+		{test: "aaaa", maxSize: 4, result: "aaaa"},
 	}
 
-	for str, test := range tests {
-		res := Truncate(str, test.MaxSize)
-		require.Equalf(t, test.Result, res, "test:%s maxsize: %d result: %s", str, test.MaxSize, res)
+	for _, test := range tests {
+		res := Truncate(test.test, test.maxSize)
+		require.Equalf(t, test.result, res, "test:%s maxsize: %d result: %s", test.test, test.maxSize, res)
 	}
-
-}
+}

Original file line number	Diff line number	Diff line change
`@@ -246,10 +246,10 @@ func LongestRepeatingSequence(s string) LongestSequence {`
`246`	`246`	`return LongestSequence{Sequence: res, Count: resCount}`
`247`	`247`	`}`
`248`	`248`
`249`		`-//Truncate a string to max length`
	`249`	`+// Truncate a string to max length`
`250`	`250`	`func Truncate(data string, maxSize int) string {`
`251`		`- if maxSize > 0 && len(data) > maxSize {`
	`251`	`+ if maxSize >= 0 && len(data) > maxSize {`
`252`	`252`	`return data[:maxSize]`
`253`	`253`	`}`
`254`	`254`	`return data`
`255`		`-}`
	`255`	`+}`