pkg/passive/ratelimit_test.go (1)

34-126: Good test coverage for the rate-limiting scenarios.

The four tests effectively cover:

• Per-source limits with custom duration
• Global rate limit fallback for unlisted sources
• Count=0 fallback to global rate limit
• Unlimited behavior when no flags are set

Consider adding a test for when rateLimit is nil to verify the fix for the nil pointer issue flagged in passive.go:

🧪 Optional: Add test for nil rateLimit handling

// TestBuildMultiRateLimiter_NilRateLimit verifies that a nil CustomRateLimit
// does not cause a panic and correctly applies the global rate limit.
func TestBuildMultiRateLimiter_NilRateLimit(t *testing.T) {
	agent := New([]string{"hackertarget"}, []string{}, false, false)

	globalRateLimit := 5
	mrl, err := agent.buildMultiRateLimiter(context.Background(), globalRateLimit, nil)
	require.NoError(t, err)
	require.NotNil(t, mrl)

	limit, err := mrl.GetLimit("hackertarget")
	require.NoError(t, err)
	assert.Equal(t, uint(globalRateLimit), limit, "source should use global rate limit when CustomRateLimit is nil")
}

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@pkg/passive/ratelimit_test.go` around lines 34 - 126, Add a new test named
TestBuildMultiRateLimiter_NilRateLimit that calls agent.buildMultiRateLimiter
with a non-zero globalRateLimit and a nil CustomRateLimit, then assert no error
and that mrl.GetLimit("hackertarget") returns the global rate
(uint(globalRateLimit)); this verifies buildMultiRateLimiter and its handling of
a nil *CustomRateLimit (reference buildMultiRateLimiter, CustomRateLimit,
GetLimit, and the new TestBuildMultiRateLimiter_NilRateLimit).

pkg/passive/ratelimit_test.go (1)

34-57: Consider adding a test for case-insensitive source name lookup.

All tests use lowercase keys (e.g., "hackertarget"), which won't catch the case mismatch issue between storage and lookup. Adding a test with mixed-case keys would validate that the lowercasing behavior works end-to-end.

🧪 Suggested test for case-insensitive lookup

// TestBuildMultiRateLimiter_CaseInsensitiveLookup verifies that per-source
// limits work regardless of source name casing in the custom map.
func TestBuildMultiRateLimiter_CaseInsensitiveLookup(t *testing.T) {
	agent := New([]string{"hackertarget"}, []string{}, false, false)

	// Simulate user providing mixed-case source name via -rls
	crl := newCustomRateLimit(
		map[string]uint{"HackerTarget": 8},
		map[string]time.Duration{"HackerTarget": time.Minute},
	)

	mrl, err := agent.buildMultiRateLimiter(context.Background(), 0, crl)
	require.NoError(t, err)
	require.NotNil(t, mrl)

	// Should still match despite case difference
	limit, err := mrl.GetLimit("hackertarget")
	require.NoError(t, err)
	assert.Equal(t, uint(8), limit, "should find per-source limit regardless of case in custom map")
}

Note: This test would currently fail due to the case mismatch bug identified in passive.go.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@pkg/passive/ratelimit_test.go` around lines 34 - 57, Add a new unit test
(e.g., TestBuildMultiRateLimiter_CaseInsensitiveLookup) alongside
TestBuildMultiRateLimiter_PerSourceLimit that constructs an agent with a
lowercase source list, then creates a custom rate limit via newCustomRateLimit
using a mixed-case key (e.g., "HackerTarget") and duration, calls
agent.buildMultiRateLimiter(context.Background(), 0, crl), and asserts
mrl.GetLimit("hackertarget") returns the configured uint value; this verifies
case-insensitive lookup end-to-end and will expose the current casing bug.