Skip to content

fix: mark LeakIX as requiring an API key#1709

Merged
dogancanbakir merged 1 commit intoprojectdiscovery:devfrom
spameier:fix/leakix-require-key
Feb 4, 2026
Merged

fix: mark LeakIX as requiring an API key#1709
dogancanbakir merged 1 commit intoprojectdiscovery:devfrom
spameier:fix/leakix-require-key

Conversation

@spameier
Copy link
Copy Markdown
Contributor

@spameier spameier commented Jan 21, 2026 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Chores
    • LeakIX integration now requires an API key to function. Previously, the key was optional. Users must provide valid credentials to use this source.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jan 21, 2026 •
edited
Loading

Walkthrough

The leakix source's KeyRequirement method is updated to return RequiredKey instead of OptionalKey, changing the API key from optional to required. This is a single-line behavior modification with no other logic alterations.

Changes

Cohort / File(s) Summary
Leakix Key Requirement
pkg/subscraping/sources/leakix/leakix.go		 Updated KeyRequirement() method return value from subscraping.OptionalKey to subscraping.RequiredKey, enforcing mandatory API key requirement

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A key requirement's tale:
Once optional, now it must prevail,
Leakix demands proof to know,
Authentication's gentle flow! 🔐

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately describes the main change: updating LeakIX source to require an API key instead of treating it as optional.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@PontusLindblom PontusLindblom mentioned this pull request Jan 30, 2026
Closed
Jigardjain
Jigardjain reviewed Feb 3, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@Jigardjain Jigardjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accurately reflects the current LeakIX API requirements
-Passes all CI checks
-Aligns with the comment in Issue #1715 from @PontusLindblom confirming LeakIX now requires API keys
-Will complement the existing workaround in sources_wo_auth_test.go

Jigardjain
Jigardjain approved these changes Feb 3, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@Jigardjain Jigardjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accurately reflects the current LeakIX API requirements
-Passes all CI checks
-Aligns with the comment in Issue #1715 from @PontusLindblom confirming LeakIX now requires API keys
-Will complement the existing workaround in sources_wo_auth_test.go

@dogancanbakir dogancanbakir merged commit a740540 into projectdiscovery:dev Feb 4, 2026
10 checks passed
@dogancanbakir dogancanbakir linked an issue Feb 4, 2026 that may be closed by this pull request
LeakIX source experiencing intermittent test failures in CI #1715
Closed
@coderabbitai coderabbitai bot mentioned this pull request Feb 8, 2026
Closed
@BrewTestBot BrewTestBot mentioned this pull request Mar 10, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jigardjain Jigardjain Jigardjain approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

LeakIX source experiencing intermittent test failures in CI

3 participants

@spameier @Jigardjain @dogancanbakir