Skip to content

add reconeer#1694

Merged
dogancanbakir merged 1 commit intodevfrom
add_reconeer
Jan 5, 2026
Merged

add reconeer#1694
dogancanbakir merged 1 commit intodevfrom
add_reconeer

Conversation

@dogancanbakir
Copy link
Copy Markdown
Member

@dogancanbakir dogancanbakir commented Jan 4, 2026 •
edited by coderabbitai bot
Loading

closes #1690

ref: https://x.com/hackerkrd/status/2002069943056318712

Summary by CodeRabbit

  • New Features

    • Added Reconeer as a new passive subdomain enumeration source with API key support for enhanced subdomain discovery.

  • Tests

    • Updated test fixtures to include Reconeer in available sources.

✏️ Tip: You can customize this high-level summary in your review settings.

@dogancanbakir dogancanbakir self-assigned this Jan 4, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jan 4, 2026 •
edited
Loading

Walkthrough

This change integrates Reconeer as a new passive subdomain enumeration source. The update includes registering the source in the passive sources registry, adding corresponding test fixtures, and implementing the full Reconeer source with API key support and HTTP-based subdomain discovery.

Changes

Cohort / File(s) Summary
Source Registration
pkg/passive/sources.go		 Adds &reconeer.Source{} to the AllSources slice and imports the reconeer package.
Test Fixtures
pkg/passive/sources_test.go		 Adds "reconeer" string to both expectedAllSources and expectedDefaultSources test fixtures.
New Source Implementation
pkg/subscraping/sources/reconeer/reconeer.go		 New file implementing the Reconeer source with HTTP-based API calls, JSON response parsing, context-aware cancellation, API key management, error handling, and streaming result delivery. Exports Source type and standard interface methods (Name, IsDefault, HasRecursiveSupport, NeedsKey, AddApiKeys, Statistics, Run).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 A reconeer joins our warren's quest,
With api keys put to the test,
New subdomains hop through network streams,
Fulfilling enumeration dreams!
One source added, more domains found,
Our discovery tools now more profound. 🔍

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title 'add reconeer' directly relates to the main change, which adds Reconeer as a new passive subdomain source.
Linked Issues check ✅ Passed The pull request successfully implements Reconeer integration by adding the source to AllSources, creating the reconeer package with full implementation, and updating tests.
Out of Scope Changes check ✅ Passed All changes are directly related to adding Reconeer support: new reconeer source implementation, integration into passive sources, and corresponding test updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitai bot reviewed Jan 4, 2026
View reviewed changes
Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2e0982c and fe41f49.

📒 Files selected for processing (3)
  • pkg/passive/sources.go
  • pkg/passive/sources_test.go
  • pkg/subscraping/sources/reconeer/reconeer.go
🧰 Additional context used
🧬 Code graph analysis (2)
pkg/passive/sources.go (2)
pkg/subscraping/sources/reconeer/reconeer.go (1)
  • Source (20-26)
pkg/subscraping/types.go (1)
  • Source (37-62)
pkg/subscraping/sources/reconeer/reconeer.go (1)
pkg/subscraping/utils.go (1)
  • PickRandom (12-20)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: Test Builds (windows-latest)
  • GitHub Check: Test Builds (macOS-latest)
  • GitHub Check: Test Builds (ubuntu-latest)
  • GitHub Check: Analyze (go)
  • GitHub Check: release-test
🔇 Additional comments (3)
pkg/passive/sources_test.go (1)

60-60: LGTM!

The test fixtures correctly include "reconeer" in both expectedAllSources and expectedDefaultSources, which aligns with the source implementation where IsDefault() returns true.

Also applies to: 104-104

pkg/passive/sources.go (1)

46-46: LGTM!

The reconeer source is properly imported and registered in the AllSources slice. The alphabetical ordering is correct, and the registration follows the established pattern for passive subdomain sources.

Also applies to: 112-112

pkg/subscraping/sources/reconeer/reconeer.go (1)

83-110: LGTM!

All helper methods are correctly implemented:

  • Name() returns the source identifier that matches test fixtures
  • IsDefault() returns true, consistent with the source being included in default sources
  • NeedsKey() returns true, which is correct as the API requires authentication
  • Statistics() properly reports all tracked metrics

Mzack9999
Mzack9999 requested changes Jan 5, 2026
View reviewed changes
@dogancanbakir dogancanbakir merged commit c1977c0 into dev Jan 5, 2026
8 of 10 checks passed
@dogancanbakir dogancanbakir deleted the add_reconeer branch January 5, 2026 10:29
@BrewTestBot BrewTestBot mentioned this pull request Jan 12, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@Mzack9999 Mzack9999 Mzack9999 approved these changes

@ehsandeep ehsandeep Awaiting requested review from ehsandeep

@knakul853 knakul853 Awaiting requested review from knakul853

Assignees

@dogancanbakir dogancanbakir

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Reconeer

2 participants

@dogancanbakir @Mzack9999