Return enumerated subdomain results in realtime by mukesh-dream11 · Pull Request #1652 · projectdiscovery/subfinder

mukesh-dream11 · 2025-10-01T16:47:11Z

Refer to #1649.

I've not tested the RemoveWildcard = true path yet, but the code looks fine to me. I've removed the original ResultCallback calls and placed them where they will be called sooner, which is hopefully acceptable.

Summary by CodeRabbit

New Features
- Results now stream in real time: discovered subdomains are emitted immediately, and entries from wildcard resolution are surfaced as they’re resolved. This reduces latency and improves interactive workflows and integrations.
Refactor
- Removed the final consolidated emission at the end of a run. Consumers should handle streaming updates during execution rather than relying on a single end-of-run callback. Existing output files and wildcard result queuing behavior remain unchanged.

coderabbitai · 2025-10-01T16:47:19Z

Walkthrough

Adds immediate ResultCallback emissions when a subdomain is discovered (if RemoveWildcard is false) and when wildcard-resolution produces a non-wildcard result; removes the final consolidated callback emission loop while keeping output writing and wildcard queuing intact.

Changes

Cohort / File(s)	Summary
Runner enumeration callbacks `pkg/runner/enumerate.go`	Emit `HostEntry` to `ResultCallback` at discovery time (when `RemoveWildcard` is false) and at wildcard-resolution time; remove the final aggregated callback emission loop; preserve output writing and wildcard result queuing.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant E as Enumerator
  participant D as DNS/Discovery
  participant W as Wildcard Resolver Pool
  participant C as ResultCallback

  rect rgba(220,235,255,0.4)
  note right of E: Discovery path (RemoveWildcard = false)
  E->>D: Discover subdomain
  D-->>E: HostEntry discovered
  E-->>C: Callback(HostEntry) [immediate]
  end

  rect rgba(235,255,220,0.4)
  note right of E: Wildcard resolution path
  E->>D: Queue candidate host(s)
  D-->>W: Submit for wildcard resolution
  W-->>E: Resolved HostEntry (non-wildcard)
  E-->>C: Callback(HostEntry) [on resolution]
  end

  rect rgba(255,230,230,0.15)
  note over E: Removed final aggregated emission loop
  end

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

I hop through hosts with nimble cheer,
Ping! A name appears — I shout it clear.
No waiting till the end of run,
I share the news as soon as it's done.
Wildcards trimmed, the stream is near — thump-thump, real-time here! 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title succinctly and accurately describes the primary change of emitting subdomain enumeration results in realtime via the updated callbacks, matching the modifications made to trigger these emissions earlier in the flow.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7e6ad51 and 50bbe41.

📒 Files selected for processing (1)

pkg/runner/enumerate.go (2 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

pkg/runner/enumerate.go (1)

pkg/resolve/resolve.go (1)

HostEntry (27-31)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

GitHub Check: Test Builds (ubuntu-latest)
GitHub Check: Test Builds (macOS-latest)
GitHub Check: Test Builds (windows-latest)
GitHub Check: Analyze (go)

🔇 Additional comments (2)

pkg/runner/enumerate.go (2)

97-99: LGTM: Real-time callback emission for non-wildcard path.

The callback is correctly invoked with a complete HostEntry (including Domain, Host, and Source) immediately upon discovery when wildcard removal is disabled. This achieves the real-time emission goal stated in the PR objectives.

131-133: LGTM: Real-time callback emission for wildcard-resolved results.

The callback correctly includes the Domain field (the issue flagged in the past review has been resolved). The HostEntry is now consistent with the non-wildcard path at lines 97-99, providing real-time emission of wildcard-resolved subdomains.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1464ef0 and 7e6ad51.

📒 Files selected for processing (1)

pkg/runner/enumerate.go (2 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

pkg/runner/enumerate.go (1)

pkg/resolve/resolve.go (1)

HostEntry (27-31)

🔇 Additional comments (1)

pkg/runner/enumerate.go (1)

97-99: Verify concurrent safety of OnResultCallback
OnResultCallback (type func(*resolve.HostEntry)) is now invoked from multiple goroutines (e.g., in enumerate.go), so any provided callback must safely handle concurrent calls.

pkg/runner/enumerate.go

dogancanbakir · 2025-10-02T11:10:04Z

Thanks for the PR!

mukesh-dream11 added 2 commits October 1, 2025 21:07

Call ResultCallback sooner

2097be5

Handle case when RemoveWildcard is true

7e6ad51

coderabbitai bot reviewed Oct 1, 2025

View reviewed changes

pkg/runner/enumerate.go Show resolved Hide resolved

Add missing domain field

50bbe41

dogancanbakir linked an issue Oct 2, 2025 that may be closed by this pull request

Return enumerated subdomain results in realtime #1653

Closed

dogancanbakir approved these changes Oct 2, 2025

View reviewed changes

dogancanbakir merged commit 1af75eb into projectdiscovery:dev Oct 2, 2025
10 checks passed

BrewTestBot mentioned this pull request Nov 19, 2025

subfinder 2.10.0 Homebrew/homebrew-core#254984

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Return enumerated subdomain results in realtime#1652

Return enumerated subdomain results in realtime#1652
dogancanbakir merged 3 commits intoprojectdiscovery:devfrom
mukesh-dream11:fix-onresult

mukesh-dream11 commented Oct 1, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Oct 1, 2025 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

dogancanbakir commented Oct 2, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

mukesh-dream11 commented Oct 1, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Poem

Pre-merge checks and finishing touches

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dogancanbakir commented Oct 2, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mukesh-dream11 commented Oct 1, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Oct 1, 2025 •

edited

Loading