Improved Subfinder SDK Usability#1466
Merged
ehsandeep merged 4 commits intoprojectdiscovery:devfrom Jan 14, 2025
Merged
Conversation
| var sourceMap map[string]map[string]struct{} | ||
| // To run subdomain enumeration on a single domain | ||
| if err = subfinder.EnumerateSingleDomainWithCtx(context.Background(), "hackerone.com", []io.Writer{output}); err != nil { | ||
| if sourceMap, err = subfinder.EnumerateSingleDomainWithCtx(context.Background(), "hackerone.com", []io.Writer{output}); err != nil { |
Check failure
Code scanning / CodeQL
Incomplete regular expression for hostnames
|
Thanks for your contribution @mielverkerken , we appreciate it! :) |
dogancanbakir
approved these changes
Dec 19, 2024
Mzack9999
approved these changes
Dec 20, 2024
ehsandeep
approved these changes
Jan 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improved Subfinder SDK Usability
The current
subfinderGo module has limited functionality as an SDK. While it allows configuring therunnerand performing enumerations, obtaining results requires passing through writers and parsing the output again, which is inefficient for programmatic use.This pull request introduces a change to make the
subfindermodule more SDK-friendly by directly returning thesourceMap. ThesourceMapcontains the enumerated subdomains along with the sources that identified them, eliminating the need to reprocess the output.Key Changes
sourceMapas a result.subfinderGo module to use thesourceMap.