Skip to content

make raw req/resp optional and jsonl as default #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ehsandeep merged 7 commits into from
Sep 27, 2023
Merged

make raw req/resp optional and jsonl as default #379

ehsandeep merged 7 commits into from
Sep 27, 2023

Conversation

@RamanaReddy0M
Copy link
Contributor

@RamanaReddy0M RamanaReddy0M commented Sep 21, 2023 •
edited
Loading

Test

✗ go run .                                                                                         

                       _ ___    
   ___  _______ __ __ (_) _/_ __
  / _ \/ __/ _ \\ \ // / _/ // /
 / .__/_/  \___/_\_\/_/_/ \_, / 
/_/                      /___/

                projectdiscovery.io

[INF] Current proxify version v0.0.12 (latest)
[INF] HTTP Proxy Listening on 127.0.0.1:8888
[INF] Socks5 Proxy Listening on 127.0.0.1:10080
[INF] Saving proxify logs to proxify_logs.jsonl

-----

✗ go run . -sr

                       _ ___    
   ___  _______ __ __ (_) _/_ __
  / _ \/ __/ _ \\ \ // / _/ // /
 / .__/_/  \___/_\_\/_/_/ \_, / 
/_/                      /___/

                projectdiscovery.io

[INF] Current proxify version v0.0.12 (latest)
[INF] HTTP Proxy Listening on 127.0.0.1:8888
[INF] Socks5 Proxy Listening on 127.0.0.1:10080
[INF] Saving proxify logs (raw) to proxify_logs

@RamanaReddy0M RamanaReddy0M self-assigned this Sep 21, 2023
@RamanaReddy0M RamanaReddy0M linked an issue Sep 21, 2023 that may be closed by this pull request
Making raw logs optional #378
Closed
github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 21, 2023
View reviewed changes
proxy.go
MaxConnsPerHost: 0,
TLSClientConfig: &tls.Config{
MinVersion: tls.VersionTLS10,
MinVersion: tls.VersionTLS10,

Check failure

Code scanning / CodeQL

Insecure TLS configuration

Using insecure TLS version VersionTLS10 for MinVersion.
@RamanaReddy0M RamanaReddy0M marked this pull request as draft September 21, 2023 14:43
@RamanaReddy0M RamanaReddy0M marked this pull request as ready for review September 21, 2023 17:23
@ehsandeep ehsandeep changed the title make raw req/resp optional make raw req/resp optional and jsonl as default Sep 25, 2023
@ehsandeep ehsandeep added the Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity. label Sep 25, 2023
tarunKoyalwar
tarunKoyalwar approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !

@ehsandeep ehsandeep merged commit 6d85048 into dev Sep 27, 2023
@ehsandeep ehsandeep deleted the issue-378-optional-raw-logs branch September 27, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@tarunKoyalwar tarunKoyalwar tarunKoyalwar approved these changes

Assignees

@RamanaReddy0M RamanaReddy0M

Labels

Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Making raw logs optional

4 participants

@RamanaReddy0M @ehsandeep @tarunKoyalwar