support custom config dir #341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Mzack9999
requested changes
Aug 2, 2023
Member
Mzack9999
left a comment
There was a problem hiding this comment.
Implementation: lgtm
suggesting a minor aesthetic change to remove panic from internals on sporadic config file read error
Mzack9999
requested changes
Aug 3, 2023
Member
Mzack9999
left a comment
There was a problem hiding this comment.
I'm getting this error (test folder doesn't exist):
$ go run . -config test
...
[INF] Current proxify version 0.0.11 (latest)
[FTL] failed to load open test/cakey.pem while saving private key got open test/cakey.pem: no such file or directory
exit status 1I think we need O_CREATE|O_TRUNC also in
Line 61 in 5d6cda1
os.Create(...)
Member
Author
|
@Mzack9999 Fixed in #340 |
ehsandeep
requested changes
Aug 10, 2023
Member
ehsandeep
left a comment
There was a problem hiding this comment.
to overwrite config dir, we should use a dedicated and separate option like in nuclei as this conflicts with -config option, which is generally used to specify the custom tool config file across all the tools.
we can make changes to make sure these cases are covered.
./proxify -config test/custom_config.yaml
./proxify -config-directory custom_dir_to_store_config_files -cdir, -config-directory string directory to store/read proxify cert/config files ($HOME/.config/proxify)
ehsandeep
approved these changes
Aug 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR fixes custom config dir support -same functionality as
nuclei. Closes #323 .Checklist