Skip to content

adding passthrough support + path fixes #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ehsandeep merged 3 commits into from
Feb 21, 2023
Merged

adding passthrough support + path fixes #227

ehsandeep merged 3 commits into from
Feb 21, 2023

Conversation

@Mzack9999
Copy link
Member

@Mzack9999 Mzack9999 commented Feb 1, 2023 •
edited
Loading

Proposed changes

Adding experimental passthrough support via new -pt host:port CLI parameter:

$ proxify -pt 192.168.1.1:443
[INF] HTTP Proxy Listening on 127.0.0.1:8888
[INF] Socks5 Proxy Listening on 127.0.0.1:10080
[INF] Saving proxify traffic to logs
...
$ curl https://192.168.1.1 --proxy http://127.0.0.1:8888 -k
$ ls -la logs/ # no request was intercepted
$

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@Mzack9999 Mzack9999 added the Type: Enhancement Most issues will probably ask for additions or changes. label Feb 1, 2023
@Mzack9999 Mzack9999 self-assigned this Feb 1, 2023
@Mzack9999 Mzack9999 linked an issue Feb 1, 2023 that may be closed by this pull request
TLS Pass Through support #207
Closed
tarunKoyalwar
tarunKoyalwar approved these changes Feb 14, 2023
View reviewed changes
Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!
@Mzack9999 tried this locally . currently it requires hostname along with port
ex: www.google.com:443 for matching host

What do you think of using regex for tls passthrough . I think it will be more convenient and easy.

Ex: when we are using firefox browser and proxy traffic through proxify . firefox makes a lot of meta requests to *.mozilla.net,*.mozilla.com *.firefox.com etc. It will be quite difficult to track and blacklist all of these with current implementation .

If we implement regex based matching it will be easy and convenient and can be done with a simple regex

tarunKoyalwar
tarunKoyalwar approved these changes Feb 19, 2023
View reviewed changes
Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment •
edited by ehsandeep
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation and Functional testing : lgtm

TODO

  • update-pt flag description
  • Update README.md Usage

@ehsandeep ehsandeep merged commit 2a78988 into dev Feb 21, 2023
@ehsandeep ehsandeep deleted the issue-207-pass-through branch February 21, 2023 21:02
@ehsandeep ehsandeep mentioned this pull request Feb 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@tarunKoyalwar tarunKoyalwar tarunKoyalwar approved these changes

Assignees

@Mzack9999 Mzack9999

Labels

Type: Enhancement Most issues will probably ask for additions or changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TLS Pass Through support

4 participants

@Mzack9999 @ehsandeep @tarunKoyalwar