fix: use fmt.Fprintf instead of WriteString(fmt.Sprintf)

dogancanbakir · dogancanbakir · commit a35650c8cd9b · 2026-03-03T21:31:08.000+03:00
diff --git a/pkg/js/libs/ldap/utils.go b/pkg/js/libs/ldap/utils.go
@@ -219,10 +219,10 @@ func DecodeSID(s string) string {
 
 	var builder strings.Builder
 	builder.WriteString("S-")
-	builder.WriteString(fmt.Sprintf("%d-", revisionLvl))
-	builder.WriteString(fmt.Sprintf("%d", authority))
+	fmt.Fprintf(&builder, "%d-", revisionLvl)
+	fmt.Fprintf(&builder, "%d", authority)
 	for _, v := range subAuthorities {
-		builder.WriteString(fmt.Sprintf("-%d", v))
+		fmt.Fprintf(&builder, "-%d", v)
 	}
 	return builder.String()
 }

Original file line number	Diff line number	Diff line change
`@@ -219,10 +219,10 @@ func DecodeSID(s string) string {`
`219`	`219`
`220`	`220`	`var builder strings.Builder`
`221`	`221`	`builder.WriteString("S-")`
`222`		`- builder.WriteString(fmt.Sprintf("%d-", revisionLvl))`
`223`		`- builder.WriteString(fmt.Sprintf("%d", authority))`
	`222`	`+ fmt.Fprintf(&builder, "%d-", revisionLvl)`
	`223`	`+ fmt.Fprintf(&builder, "%d", authority)`
`224`	`224`	`for _, v := range subAuthorities {`
`225`		`- builder.WriteString(fmt.Sprintf("-%d", v))`
	`225`	`+ fmt.Fprintf(&builder, "-%d", v)`
`226`	`226`	`}`
`227`	`227`	`return builder.String()`
`228`	`228`	`}`