Skip to content

-char-limit is not honoured in non-bulk mode #137

@justinsteven

Description

@justinsteven

Notify version:

% ./notify -version

             __  _ ___
  ___  ___  / /_(_) _/_ __
 / _ \/ _ \/ __/ / _/ // /
/_//_/\___/\__/_/_/ \_, / v1.0.1
                   /___/

                projectdiscovery.io

Use with caution. You are responsible for your actions
Developers assume no liability and are not responsible for any misuse or damage.
[INF] Current Version: 1.0.1

Current Behavior:

In the case of -bulk, -char-limit splits the lines being sent to the notification service so that they're of a maximum length. Without -bulk this splitting isn't done. It could cause very long lines to be sent to notification services without being split, which could cause failure to send notifications.

Demo:

% ./notify -i /etc/issue -char-limit 8

             __  _ ___
  ___  ___  / /_(_) _/_ __
 / _ \/ _ \/ __/ / _/ // /
/_//_/\___/\__/_/_/ \_, / v1.0.1
                   /___/

                projectdiscovery.io

Use with caution. You are responsible for your actions
Developers assume no liability and are not responsible for any misuse or damage.
Using default provider config: /home/justin/.config/notify/provider-config.yaml
Debian GNU/Linux 10 \n \l

% ./notify -i /etc/issue -char-limit 8 -bulk

             __  _ ___
  ___  ___  / /_(_) _/_ __
 / _ \/ _ \/ __/ / _/ // /
/_//_/\___/\__/_/_/ \_, / v1.0.1
                   /___/

                projectdiscovery.io

Use with caution. You are responsible for your actions
Developers assume no liability and are not responsible for any misuse or damage.
Using default provider config: /home/justin/.config/notify/provider-config.yaml
Debian G
NU/Linux
 10 \n \
l

(Note that this demo abuses #136 by using notify's output to show what was sent to the notification service)

Expected Behavior:

Lines should be chunked per -char-limit whether -bulk is given or not

Steps To Reproduce:

Anything else:

Metadata

Metadata

Assignees

No one assigned

    Labels

    Priority: MediumThis issue may be useful, and needs some attention.Status: CompletedNothing further to be done with this issue. Awaiting to be closed.Type: BugInconsistencies or issues which will cause an issue or problem for users or implementors.

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions