Fix the release workflow to release assets for Linux#1587
Fix the release workflow to release assets for Linux#1587Mzack9999 merged 2 commits intoprojectdiscovery:devfrom
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| env: | ||
| GITHUB_TOKEN: "${{ secrets.GITHUB_TOKEN }}" | ||
| SLACK_WEBHOOK: "${{ secrets.RELEASE_SLACK_WEBHOOK }}" | ||
| DISCORD_WEBHOOK_ID: "${{ secrets.DISCORD_WEBHOOK_ID }}" | ||
| DISCORD_WEBHOOK_TOKEN: "${{ secrets.DISCORD_WEBHOOK_TOKEN }}" |
There was a problem hiding this comment.
GitHub Access Token is required to create a release.
Also, in linux-amd64.yml slack and discord integrations are enabled.
naabu/.goreleaser/linux-amd64.yml
Lines 28 to 37 in a687d97
| SLACK_WEBHOOK: "${{ secrets.RELEASE_SLACK_WEBHOOK }}" | ||
| DISCORD_WEBHOOK_ID: "${{ secrets.DISCORD_WEBHOOK_ID }}" | ||
| DISCORD_WEBHOOK_TOKEN: "${{ secrets.DISCORD_WEBHOOK_TOKEN }}" |
There was a problem hiding this comment.
In linux-arm64.yml, slack and discord integration are disabled.
naabu/.goreleaser/linux-arm64.yml
Lines 28 to 37 in a687d97
| with: | ||
| version: latest | ||
| args: release -f .goreleaser/linux-amd64.yml --clean | ||
| workdir: / |
There was a problem hiding this comment.
https://github.com/goreleaser/goreleaser-action#inputs
workdir | String | . | Working directory (below repository root)
I'm not sure why workdir: / was set, but I think this is a bug.
Close #1586
Test
I've confirmed the issue was solved by running the workflow on my fork.
https://github.com/szksh-lab-2/naabu/releases/tag/v2.3.7-3
https://github.com/szksh-lab-2/naabu/actions/runs/19406245232