Walkthrough

This PR implements MAC address lookup functionality for private IP addresses. It adds a MacAddress field to HostResult and Result structs, introduces ARP-based MAC discovery via the GetMacAddress() function, and propagates MAC address data through JSON and CSV output paths using new *WithMac helper functions.

Changes

Sequence Diagram(s)

sequenceDiagram
    participant Runner as runner.go
    participant Results as results.go
    participant ARP as ARP Table
    participant Output as output.go
    
    Runner->>Results: GetIPsPorts(target)
    Results->>Results: Resolve IP
    alt Private IP detected
        Results->>Results: isPrivateIP(ip)
        Results->>Results: GetMacAddress(target)
        Results->>ARP: Query ARP table (OS command)
        ARP-->>Results: MAC address
        Results->>Results: Set hostResult.MacAddress
    end
    Results-->>Runner: Return HostResult with MacAddress
    
    Runner->>Output: WriteJSONOutputWithMac(..., macAddress, ...)
    Output->>Output: Populate Result.MacAddress
    Output-->>Runner: JSON output written
    
    Runner->>Output: WriteCsvOutputWithMac(..., macAddress, ...)
    Output->>Output: Populate Result.MacAddress
    Output-->>Runner: CSV output written

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

• ARP integration complexity: The GetMacAddress() function uses OS-specific shell commands to query ARP tables; verify cross-platform compatibility (Linux/macOS/Windows) and error handling for edge cases.
• Private IP detection logic: Ensure the isPrivateIP() helper correctly identifies all RFC1918 ranges and link-local addresses.
• Output path refactoring: Multiple branches in runner.go now call *WithMac variants; confirm all call sites are updated consistently and backward compatibility is maintained via delegation.
• MAC propagation through result chain: Trace the MacAddress field from HostResult → Result → JSON/CSV output to ensure no data is lost or duplicated.

Poem

🐰 A hop through networks, both far and near,
MAC addresses found, crystal clear!
ARP tables whisper their secrets true,
Private IPs yield their hardware view,
Output streams flowing with addresses bright,
Discovery complete—the network's delight! ✨

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

@coderabbitai create an issue for this PR related to implementing MAC Address lookup for private ips

#!/bin/bash
# Get details about the PR to understand context
gh pr view 1580 --json title,body,url

#!/bin/bash
# Create the issue for implementing MAC Address lookup for private IPs
gh issue create \
  --title "Implement MAC Address lookup for private IPs" \
  --body "This issue tracks the implementation of MAC Address lookup functionality for private IP addresses.

**Context:**
This is a follow-up from PR #1580 which added initial MAC address support.

**Requested by:** @Mzack9999

**Related PR:** https://github.com/projectdiscovery/naabu/pull/1580" \
  --assignee Mzack9999

@Mzack9999: I've created issue #1581 for implementing MAC Address lookup for private IPs. The issue has been assigned to you and includes a reference to this PR.

You can view it here: #1581