Skip to content

Fix protocol string representation in Port#1438

Merged
Mzack9999 merged 4 commits intoprojectdiscovery:devfrom
Mehran-Seifalinia:dev
Apr 1, 2025
Merged

Fix protocol string representation in Port#1438
Mzack9999 merged 4 commits intoprojectdiscovery:devfrom
Mehran-Seifalinia:dev

Conversation

@Mehran-Seifalinia
Copy link
Copy Markdown
Contributor

@Mehran-Seifalinia Mehran-Seifalinia commented Mar 28, 2025 •
edited by coderabbitai bot
Loading

Used p.Protocol.String() instead of %d to ensure proper string representation

Summary by CodeRabbit

  • New Features

    • Introduced a new method for detailed port representation, providing additional context on the port's protocol and TLS status.

  • Refactor

    • Simplified the output of the port display method to show only the port number for a cleaner presentation.
    • Enhanced error handling during the closure of the naabuRunner to improve robustness.

  • Chores

    • Removed several indirect dependencies from the project, streamlining the overall dependency management.

@Mehran-Seifalinia
Fix protocol string representation in Port
ef4fa15 
Used p.Protocol.String() instead of %d to ensure proper string representation
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 28, 2025 •
edited
Loading

Walkthrough

The changes in pkg/port/port.go involve modifications to the Port struct and its methods. The String method has been updated to return only the port number as a string, while a new method, StringWithDetails, has been added to provide a more detailed representation of the Port instance. Additionally, the go.mod file has seen the removal of several indirect dependencies, streamlining the project's dependency management. Enhanced error handling has also been introduced in the naabuRunner closure process in cmd/naabu/main.go.

Changes

File Changes
pkg/port/port.go - Method added: func (p *Port) StringWithDetails() string.
- Updated String method to return only the port number as a string.
go.mod - Removed dependencies: github.com/projectdiscovery/katana v1.1.2, github.com/Knetic/govaluate v3.0.0+incompatible, github.com/PuerkitoBio/goquery v1.8.1, github.com/andybalholm/cascadia v1.3.2, github.com/hashicorp/go-version v1.6.0, github.com/hdm/jarm-go v0.0.7, github.com/kataras/jwt v0.1.8, github.com/mitchellh/mapstructure v1.5.0, github.com/projectdiscovery/dsl v0.3.5, github.com/sashabaranov/go-openai v1.14.2, github.com/spaolacci/murmur3 v1.1.0.
cmd/naabu/main.go - Enhanced error handling for naabuRunner.Close() to log errors if the closure fails.

Poem

Oh, the lines I hop and bound,
Code carrots scattered all around.
The port's number shines so bright,
With details added, what a sight!
Dependencies trimmed, we dance with glee,
Hopping through code, so wild and free!
🐰✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between f0517be and 88748ec.

📒 Files selected for processing (1)
  • cmd/naabu/main.go (1 hunks)
🔇 Additional comments (1)
cmd/naabu/main.go (1)

35-37: Good addition of error handling for runner closure.

The introduction of proper error handling for naabuRunner.Close() is a valuable improvement. This enhancement ensures that any issues encountered when closing the runner are now logged appropriately, which is especially important during a CTRL+C interrupt when users need to know if resources weren't properly released.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@GeorginaReeder
Copy link
Copy Markdown

GeorginaReeder commented Mar 31, 2025

Thanks for your contribution @Mehran-Seifalinia ! :)

@ehsandeep ehsandeep requested a review from Mzack9999 April 1, 2025 09:45
@Mzack9999 Mzack9999 merged commit 1d2f1f7 into projectdiscovery:dev Apr 1, 2025
9 of 10 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Jul 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mzack9999 Mzack9999 Mzack9999 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Mehran-Seifalinia @GeorginaReeder @Mzack9999