feat: convert timeout flag to support time formats (e.g., 5s, 100ms)#1344
Merged
Mzack9999 merged 2 commits intoprojectdiscovery:devfrom Jan 20, 2025
soonghee2:dev
Merged
feat: convert timeout flag to support time formats (e.g., 5s, 100ms)#1344Mzack9999 merged 2 commits intoprojectdiscovery:devfrom soonghee2:dev
Mzack9999 merged 2 commits intoprojectdiscovery:devfrom
soonghee2:dev
Conversation
|
Thanks for your contribution @soonghee2 ! :) |
Mzack9999
approved these changes
Jan 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
flagSet.DurationVarto support time formats (e.g., 5s, 500ms).Why is this needed?
Related Issue
timeoutflag from int to DurationVar #1321detailed
Change the
Option.timeoutvariable type totime.Duration.Declare a new
Option.StrTimeoutfield as astringto receive the timeout option in string format.If the string represents an integer, interpret it as milliseconds (as before).
If the string is in formats like
3sor1m, parse it directly as atime.Durationwithtime.ParseDuration.