Fix units (seconds -> milliseconds) in a description of Timeout field in Options struct#1314
Merged
Mzack9999 merged 1 commit intoprojectdiscovery:devfrom Dec 23, 2024
Merged
Conversation
Contributor
Author
|
Also, if I am not mistaken by looking at the code and playing with it, the Timeout field is used only in CONNECT scans, am I correct? Then the comment is also quite misleading |
|
Thanks for bringing this up @HappyStoic , we'll take a look into it! |
Mzack9999
approved these changes
Dec 23, 2024
Member
|
@HappyStoic Nice catch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a typo saying Timeout field is in seconds. It's actually milliseconds. This confused me a lot.
References that the value is actually interpreted as milliseconds: