ci(goreleaser): Fix the failure of release workflow#1263
ci(goreleaser): Fix the failure of release workflow#1263ehsandeep merged 3 commits intoprojectdiscovery:mainfrom suzuki-shunsuke:ci-fix-release
Conversation
--rm-dist was deprecated. https://goreleaser.com/deprecations/?h=dep#-rm-dist The release workflow failed. https://github.com/projectdiscovery/naabu/actions/runs/11593776126/job/32278527815 ``` /opt/hostedtoolcache/goreleaser-action/2.3.2/x64/goreleaser release -f .goreleaser/linux.yml --rm-dist ⨯ command failed error=unknown flag: --rm-dist Error: The process '/opt/hostedtoolcache/goreleaser-action/2.3.2/x64/goreleaser' failed with exit code 1 ```
Fix the warning. ```console $ goreleaser check v2/.goreleaser/linux.yml • only configurations files on version: 2 are supported, yours is version: 0 , please update your configuration • checking path=v2/.goreleaser/linux.yml • 1 configuration file(s) validated • thanks for using goreleaser! ```
|
Oh? Assets were released somehow. https://github.com/projectdiscovery/naabu/releases/tag/v2.3.2 
|
|
@suzuki-shunsuke we fixed it in #1262 and yes, since automed CI failed, we pushed the binary based on latest commit on main. |
|
Oh, I see. #1262 was merged in dev branch, so I missed it. |
|
Should I close this pr? |
|
Thank you for merging this pr! |
|
BTW, I can't find any document about https://github.com/search?q=repo%3Aprojectdiscovery%2Fnaabu%20dev&type=code Should we send pull requests to dev branch? |
|
@suzuki-shunsuke That’s correct. For most OSS projects, we push new code to the dev branch and move it to main when creating a release. You can always pull the latest changes from dev and create a PR against the dev branch. |
|
Got it. Thank you for your explanation! |
--rm-distwas deprecated.https://goreleaser.com/deprecations/?h=dep#-rm-dist
The release workflow failed.
https://github.com/projectdiscovery/naabu/actions/runs/11593776126/job/32278527815