Skip to content

improvements in stream mode#74

Merged
ehsandeep merged 1 commit intodevfrom
issue-136-stream-mode
Feb 2, 2022
Merged

improvements in stream mode#74
ehsandeep merged 1 commit intodevfrom
issue-136-stream-mode

Conversation

@Mzack9999
Copy link
Copy Markdown
Member

@Mzack9999 Mzack9999 commented Jan 28, 2022 •
edited
Loading

Proposed changes

This PR improves stream decoding of large JSON with the following improvements:

  • better handling of nil tokens
  • avoid loops

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Notes

Fixes https://github.com/projectdiscovery/jira-backlogs/issues/136

@Mzack9999
improvements in stream mode
686df6b 
- better handling of nil tokens
- avoid loops
@Mzack9999 Mzack9999 added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Jan 28, 2022
@Mzack9999 Mzack9999 self-assigned this Jan 28, 2022
@Mzack9999 Mzack9999 added the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label Jan 28, 2022
@ehsandeep ehsandeep merged commit 90ac902 into dev Feb 2, 2022
@ehsandeep ehsandeep deleted the issue-136-stream-mode branch February 2, 2022 17:39
@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@Ice3man543 Ice3man543 Ice3man543 approved these changes

Assignees

@Mzack9999 Mzack9999

Labels

Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Mzack9999 @ehsandeep @Ice3man543