Skip to content

Add integration tests + docs#170

Merged
ehsandeep merged 2 commits intodevfrom
issue-124-add-integration-test
Mar 30, 2023
Merged

Add integration tests + docs#170
ehsandeep merged 2 commits intodevfrom
issue-124-add-integration-test

Conversation

@RamanaReddy0M
Copy link
Copy Markdown
Contributor

@RamanaReddy0M RamanaReddy0M commented Mar 30, 2023 •
edited by ShubhamRasal
Loading

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Add docs + example
  • Add integration test

@RamanaReddy0M RamanaReddy0M linked an issue Mar 30, 2023 that may be closed by this pull request
Using chaos-client as library #124
Closed
2 tasks
@github-advanced-security
Copy link
Copy Markdown

github-advanced-security bot commented Mar 30, 2023

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@github-advanced-security
Copy link
Copy Markdown

github-advanced-security bot commented Mar 30, 2023

You have successfully added a new CodeQL configuration .github/workflows/codeql-analysis.yml:analyze/language:go. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

ShubhamRasal
ShubhamRasal approved these changes Mar 30, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@ShubhamRasal ShubhamRasal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm-
Notes:

  • added callback functionality
  • chaos-client as a lib example
  • integration tests

@ehsandeep ehsandeep merged commit f71582c into dev Mar 30, 2023
@ehsandeep ehsandeep deleted the issue-124-add-integration-test branch March 30, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@ShubhamRasal ShubhamRasal ShubhamRasal approved these changes

Assignees

@RamanaReddy0M RamanaReddy0M

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Using chaos-client as library

4 participants

@RamanaReddy0M @github-advanced-security @ehsandeep @ShubhamRasal