Skip to content

Refactoring internal error handling#100

Merged
ehsandeep merged 1 commit intodevfrom
issue-96-errors
Aug 8, 2022
Merged

Refactoring internal error handling#100
ehsandeep merged 1 commit intodevfrom
issue-96-errors

Conversation

@Mzack9999
Copy link
Copy Markdown
Member

@Mzack9999 Mzack9999 commented Jul 12, 2022 •
edited
Loading

Proposed changes

This PR improves internal error handling and uses the http standard library to compare status codes

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@Mzack9999 Mzack9999 added the Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity. label Jul 12, 2022
@Mzack9999 Mzack9999 self-assigned this Jul 12, 2022
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jul 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Mzack9999 Mzack9999 added the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label Jul 12, 2022
@Mzack9999 Mzack9999 requested a review from Ice3man543 July 31, 2022 06:44
@ehsandeep ehsandeep merged commit 76c8cdc into dev Aug 8, 2022
@ehsandeep ehsandeep deleted the issue-96-errors branch August 8, 2022 18:53
@ehsandeep ehsandeep removed the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ice3man543 Ice3man543 Ice3man543 approved these changes

Assignees

@Mzack9999 Mzack9999

Labels

Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Mzack9999 @Ice3man543 @ehsandeep