feat: support auto reconnect for ReverseWebsocketAdapter#621
Merged
ryoii merged 4 commits intoproject-mirai:masterfrom Dec 12, 2022
Merged
feat: support auto reconnect for ReverseWebsocketAdapter#621ryoii merged 4 commits intoproject-mirai:masterfrom
ryoii merged 4 commits intoproject-mirai:masterfrom
Conversation
Karlatemp
reviewed
Sep 10, 2022
Comment on lines
+45
to
+52
| while (client.isActive) { | ||
| try { | ||
| client.ws(buildWsRequest(destination, setting)) { | ||
| webSocketSession = this | ||
|
|
||
| handleReverseWs(this@WsClient) | ||
| handleReverseWs(this@WsClient) | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
是不是没处理掉线期间新消息进入这个 old session 的问题 (suspend fun send(content: String))
在等待重连的时候 send 被执行不会有问题吗
Contributor
Author
There was a problem hiding this comment.
我让 ws session 变成 nullable 了，不过可能还是会有 data race...
Contributor
Author
|
感谢 review，明天我会尝试修复这些东西（）
|
Member
|
没问题啊， mah是jvm only的 |
Contributor
Author
主要是担心其他 engine 的行为不同（毕竟 ktor） |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: it seemed that I directly imported exceptions from
java.net.Disclaimer: I don't know kotlin.