Fix setImageFromContent regex to extract full image uri #254
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Because
setImageFromContentwas only matching URLs up to the file extension, it stripped off any query parameters. In practice this means:https://www.reddit.com/r/minecraft.rss) would fall back to a link without query string.For example, given the URL:
the old regex would truncate it to:
which is not a valid, fully-qualified URL
Fix
Added url decoding
Before running the URL regex, we now unescape the most common XML/HTML entities (
&amp;,&,",<,>) so that ampersands and other characters are restored to their literal formExtended the URL regex to capture query parameters