fix Renderer2D's get when called from MediaElement #3155
Conversation
|
I agree with your sentiment but wonder how this situation came to be. Line 2637 in 5a46133 Line 29 in 5a46133 Line 26 in 5a46133 Line 144 in 5a46133 p5.js/src/webgl/p5.RendererGL.js Line 176 in 5a46133 Searching for .elt = I get these results:Line 44 in 5a46133 Line 585 in 5a46133 Line 723 in 5a46133 and a comment about checking if the canvas is associated with the p5 instance Lines 1938 to 1939 in 5a46133 Some of the places that assign canvas also assign elt afterwards. There seems to be a thought behind this. If we decide to not go with your suggestion I really want that thought to be well documented. |
|
i'm guessing it's just a consequence of how things came together organically over time. perhaps |
|
|
|
i think that should be a bit better. the issue was that the canvas was not initialized before delegating the calls to the 2d renderer. the elt/canvas issue can wait for another day ;-) |
|
thanks! |
fixes #3153
yet another confusion between
this.canvasandthis.eltIMHO, since the Renderers (andp5itself) areinstanceof p5.Elementwe should remove those classes'this.canvasproperties and change all the code to use thep5.Element.eltvariable. having two variables (sometimes) that serve the same purpose requires code like this:p5.js/src/core/p5.Renderer2D.js
Line 112 in 5a46133
p5.js/src/image/pixels.js
Line 408 in 5a46133
p5.js/src/webgl/p5.Texture.js
Line 60 in 5a46133