Skip to content

[INFRA] Improve usage of the r-lib action #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tbouffard merged 4 commits into from
Apr 25, 2022
Merged

[INFRA] Improve usage of the r-lib action #79

tbouffard merged 4 commits into from
Apr 25, 2022

Conversation

@tbouffard
Copy link
Member

@tbouffard tbouffard commented Apr 24, 2022

Replace custom configuration and bash script by lib-r action

@tbouffard
[INFRA] Improve usage of the r-lib action
23b5e76 
Replace custom configuration and bash script by lib-r action
@tbouffard tbouffard added the chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) label Apr 24, 2022
tbouffard
tbouffard commented Apr 24, 2022
View reviewed changes
@tbouffard
Copy link
Member Author

tbouffard commented Apr 24, 2022 •
edited
Loading

ℹ️ I have check the logs to ensure we still run the same checks
The only difference is that, now we don't see

* checking CRAN incoming feasibility ... Note_to_CRAN_maintainers
Maintainer: ‘Celine Souchet <celine.souchet@bonitasoft.com>’

This is because the actions set _R_CHECK_CRAN_INCOMING_ to false (see https://github.com/r-lib/actions/blob/v2.2.1/check-r-package/action.yaml#L32). As this is an informational message and we have dedicated checks of the source package that runs afterwards, this is ok.

@tbouffard tbouffard marked this pull request as ready for review April 24, 2022 18:04
@tbouffard tbouffard merged commit f59c3e6 into main Apr 25, 2022
@tbouffard tbouffard deleted the infra/gh_wf_more_usage_of_lib-r_action branch April 25, 2022 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@csouchet csouchet csouchet approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tbouffard @csouchet