[DOC] Improve shiny application example in README #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbouffard
commented
Oct 21, 2021
| ui <- shinyUI(fluidPage( | ||
| titlePanel("Display bpmn diagrams with execution data"), | ||
| bpmnVisualizationOutput('bpmnContainer') | ||
| bpmnVisualization::bpmnVisualizationOutput('bpmnContainer') |
Member
Author
There was a problem hiding this comment.
❓ not sure that a change is needed as the bpmnVisualizationOutput function is probably only provided by our package regarding its name.
Contributor
There was a problem hiding this comment.
When I wrote my article, I tested exactly this code: https://gist.github.com/csouchet/39a1d93fd28a78070b88050669fb4204#file-shiny-app-r
And it works without the bpmnVisualization::.
So we can keep as it is 🙂
| server = function(input, output) { | ||
| # renderBpmnVisualization is the R bridge function to the html widgets | ||
| output$bpmnContainer <- renderBpmnVisualization({ displayBpmn() }) | ||
| output$bpmnContainer <- bpmnVisualization::renderBpmnVisualization({ displayBpmn() }) |
Member
Author
There was a problem hiding this comment.
❓ same here with renderBpmnVisualization
csouchet
approved these changes
Nov 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
bpmnVisualizationpackage install and load: this has already been explained, so this is implicit.Always use the
bpmnVisualizationscope when calling functions to ensure no ambiguity