feat(overlay): allow to set the overlay position #210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
♻️ PR Preview ba84537 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
89ccd23 to
81ac928
Compare
81ac928 to
6b030db
Compare
6b030db to
11411c0
Compare
tbouffard
approved these changes
Mar 13, 2023
Member
tbouffard
left a comment
There was a problem hiding this comment.
LGTM, I like the refactor of the JS bridge code. Easier to read and more compact.
I suggested a minor changes in the documentation to have a more complete live example.
| style: overlay.style ?? (x.enableDefaultOverlayStyle && buildDefaultOverlayStyle(elementsByIds[0].bpmnSemantic.isShape)), | ||
| position: elementsByIds[0].bpmnSemantic.isShape ? 'top-center' : 'middle', | ||
| }; | ||
| renderValue: function({bpmnContent, overlays, enableDefaultOverlayStyle}) { |
Member
There was a problem hiding this comment.
praise: nice to use object destructuring. This makes the code easier to read!
ddb6eeb to
ba84537
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #207
Closes #14