Skip to content

Conversation

@csouchet
Copy link
Contributor

@csouchet csouchet commented Mar 8, 2023

No description provided.

@csouchet csouchet added depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first refactoring Code refactoring labels Mar 8, 2023
@csouchet csouchet changed the title refactoring(test): format and cut tests refactor(test): format and cut tests Mar 8, 2023
@github-actions
Copy link

github-actions bot commented Mar 8, 2023

🎊 PR Preview 378d358 has been successfully built and deployed to https://process-analytics-bpmn-visualization-R-pr_preview-pr-209.surge.sh

🕐 Build time: 0.012s

🤖 By surge-preview

@csouchet csouchet marked this pull request as ready for review March 13, 2023 12:21
Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

res$label,
"this"
)
describe("create_overlay works", {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Nice! Finally we have one check per test!

@csouchet csouchet removed the depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first label Mar 13, 2023
@csouchet csouchet merged commit fb1ad3c into main Mar 13, 2023
@csouchet csouchet deleted the format_tests branch March 13, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactoring Code refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants