Skip to content

[REFACTOR] Rename the package as bpmnVisualizationR #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
csouchet merged 7 commits into from
Dec 29, 2022
Merged

[REFACTOR] Rename the package as bpmnVisualizationR #172

csouchet merged 7 commits into from
Dec 29, 2022

Conversation

@csouchet
Copy link
Contributor

@csouchet csouchet commented Dec 16, 2022 •
edited
Loading

⚠️⚠️⚠️ This is a breaking change. ⚠️⚠️⚠️

Users of the package must:

  • reinstall it from scratch
  • remove the old bpmnVisualization package
  • update usage of the package functions if they prefix them by the name of the package

Other information

Ensure the breaking change is documented in the release notes.

@csouchet csouchet added documentation Improvements or additions to documentation chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) labels Dec 16, 2022
@github-actions
Copy link

github-actions bot commented Dec 16, 2022 •
edited
Loading

🎊 PR Preview e881bdd has been successfully built and deployed to https://process-analytics-bpmn-visualization-R-pr_preview-pr-172.surge.sh

🕐 Build time: 0.013s

🤖 By surge-preview

@csouchet csouchet requested a review from tbouffard December 16, 2022 14:06
@csouchet csouchet marked this pull request as ready for review December 16, 2022 14:07
@tbouffard
Copy link
Member

tbouffard commented Dec 16, 2022

Can we merge #149 first?

@csouchet
Copy link
Contributor Author

csouchet commented Dec 16, 2022

Can we merge #149 first?

My answer for #149 https://github.com/process-analytics/bpmn-visualization-R/pull/149/files#r1050956928 🙂

@tbouffard
Copy link
Member

tbouffard commented Dec 20, 2022

#149 has been merged, please rebase/update this PR accordingly.

@tbouffard tbouffard added the rebase needed 💥 Pull request that must be rebased on the latest master commit prior being reviewed or merged label Dec 20, 2022
@csouchet csouchet force-pushed the rename_as_bpmnVisualizationR branch from 6848c1c to 1db6bcd Compare December 20, 2022 16:22
@csouchet csouchet removed the rebase needed 💥 Pull request that must be rebased on the latest master commit prior being reviewed or merged label Dec 20, 2022
@tbouffard
Copy link
Member

tbouffard commented Dec 21, 2022

The workflow that updates the bpmn-visualization ts library should be updated as well

@tbouffard tbouffard removed the documentation Improvements or additions to documentation label Dec 21, 2022
@tbouffard tbouffard changed the title [INFRA] Rename the package as bpmnVisualizationR [REFACTOR] Rename the package as bpmnVisualizationR Dec 29, 2022
@tbouffard tbouffard added refactoring Code refactoring and removed chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) labels Dec 29, 2022
tbouffard
tbouffard reviewed Dec 29, 2022
View reviewed changes
csouchet
csouchet commented Dec 29, 2022
View reviewed changes
csouchet
csouchet commented Dec 29, 2022
View reviewed changes
csouchet
csouchet commented Dec 29, 2022
View reviewed changes
csouchet
csouchet commented Dec 29, 2022
View reviewed changes
@csouchet @tbouffard
Apply suggestions from code review
d38d008 
Co-authored-by: Thomas Bouffard <27200110+tbouffard@users.noreply.github.com>
csouchet
csouchet commented Dec 29, 2022
View reviewed changes
csouchet
csouchet commented Dec 29, 2022
View reviewed changes
csouchet
csouchet commented Dec 29, 2022
View reviewed changes
@csouchet csouchet requested a review from tbouffard December 29, 2022 10:09
tbouffard and others added 2 commits December 29, 2022 11:32
@tbouffard @csouchet
Improve wording in the gh workflow
f72190e 
Co-authored-by: Souchet Céline <4921914+csouchet@users.noreply.github.com>
@tbouffard @csouchet
gh workflow: improve wording
e881bdd 
Co-authored-by: Souchet Céline <4921914+csouchet@users.noreply.github.com>
tbouffard
tbouffard approved these changes Dec 29, 2022
View reviewed changes
Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csouchet csouchet merged commit 9922a45 into main Dec 29, 2022
@csouchet csouchet deleted the rename_as_bpmnVisualizationR branch December 29, 2022 10:44
This was referenced Jan 6, 2023
Open
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tbouffard tbouffard tbouffard approved these changes

Assignees

No one assigned

Labels

refactoring Code refactoring

Projects

No open projects
Rename components
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@csouchet @tbouffard