Skip to content

Update wording in the tutorials#48

Merged
francois-rozet merged 9 commits intoprobabilists:masterfrom
psteinb:psteinb_wording_tutorials
Jun 6, 2024
Merged

Update wording in the tutorials#48
francois-rozet merged 9 commits intoprobabilists:masterfrom
psteinb:psteinb_wording_tutorials

Conversation

@psteinb
Copy link
Copy Markdown
Contributor

@psteinb psteinb commented Mar 28, 2024

While I was working through the tutorial (which are great!), I took the liberty of refining some wording. I very few mistakes of English language. I also added some bits here and there to make the tutorials more readable (for someone like me). I hope you find this useful.

@psteinb
Copy link
Copy Markdown
Contributor Author

psteinb commented Mar 28, 2024

Note, I used nbterm to edit the notebooks. Notebooks are not great for diffing and creating PRs in general when opened with jupyter. In any case, I observed that nbterm replaced some characters with unicode equivalents. Whoever reviews this PR, please have a look at the notebooks locally first. They view fine on my box, but you never know.

Copy link
Copy Markdown
Member

@francois-rozet francois-rozet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @psteinb, thanks for the feedback and fixes! I agree with most of your additions but made a few wording suggestions.

I still have to check that the UTF-8 edits display correctly in the docs and locally.

@francois-rozet francois-rozet changed the title wording updates for the tutorial Update wording in the tutorials Mar 29, 2024
psteinb and others added 5 commits April 11, 2024 15:11
Co-authored-by: François Rozet <francois.rozet@outlook.com>
Co-authored-by: François Rozet <francois.rozet@outlook.com>
Co-authored-by: François Rozet <francois.rozet@outlook.com>
Co-authored-by: Peter Steinbach <p.steinbach@hzdr.de>
@francois-rozet francois-rozet merged commit 3994bfd into probabilists:master Jun 6, 2024
@psteinb
Copy link
Copy Markdown
Contributor Author

psteinb commented Jun 6, 2024

Just saw that this is merged. Thanks so much for the trust. And sorry for not replying to your question here. Is this still an open issue?

@francois-rozet
Copy link
Copy Markdown
Member

No problem, thank you for the edits, I think the tutorial is much clearer now!

Is this still an open issue?

I think its fine like it is now. Feel free to open another PR if you want to improve the tutorials (or add new ones), though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants