Skip to content

fix: fix MySQL and stripped_partial_indexes test issues#5793

Merged
jacek-prisma merged 1 commit intomainfrom
test/fix-mysql-test-issues
Mar 11, 2026
Merged

fix: fix MySQL and stripped_partial_indexes test issues#5793
jacek-prisma merged 1 commit intomainfrom
test/fix-mysql-test-issues

Conversation

@jacek-prisma
Copy link
Copy Markdown
Contributor

@jacek-prisma jacek-prisma commented Mar 9, 2026 •
edited by coderabbitai bot
Loading

Fixes:

/test-all

Summary by CodeRabbit

  • Tests
    • Expanded query engine testing to support MariaDB MySQL WASM target compatibility alongside MySQL 8 configurations.
    • Refactored test validation methodology to use programmatic assertions for improved reliability.
    • Updated schema describer test expectations to reflect current field handling for index structures.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 9, 2026 •
edited
Loading

Walkthrough

Test suite updates across query engine, write tests, and schema describer tests. Query engine tests now target MariaDB WASM alongside MySQL 8. Snapshot-based assertions replaced with programmatic validations in data type tests. Schema describer tests updated to reflect new stripped_partial_indexes field in expected output.

Changes

Cohort / File(s) Summary
Query Engine Data Type Tests
query-engine/connector-test-kit-rs/query-engine-tests/tests/queries/data_types/native/mysql.rs		 Test suite annotations updated to include MariaDB WASM target across datetime, mysql_decimal, mysql_string, and mysql_bytes modules. Snapshot-based assertion in mysql_decimal replaced with programmatic extraction and explicit assertions on float, dfloat, and decFloat fields.
Write Tests - Native Types
query-engine/connector-test-kit-rs/query-engine-tests/tests/writes/data_types/native_types/mysql.rs		 Snapshot-based validation in native_decimal_type replaced with explicit query execution, result extraction, and direct field assertions for float, dfloat, and decFloat values.
Schema Describer Tests
schema-engine/sql-schema-describer/tests/describers/mysql_describer_tests.rs, schema-engine/sql-schema-describer/tests/describers/postgres_describer_tests.rs		 Added stripped_partial_indexes field to expected SqlSchema snapshots in all_mysql_column_types_must_work, all_mariadb_column_types_must_work, multiple_schemas_are_described, and multiple_schemas_with_same_foreign_key_are_described tests.
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 41.67% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly addresses the main changes: fixing MySQL test issues and restoring stripped_partial_indexes entries in test snapshots.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch test/fix-mysql-test-issues

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 9, 2026

Merging this PR will not alter performance

✅ 11 untouched benchmarks
⏩ 11 skipped benchmarks1

Comparing test/fix-mysql-test-issues (6ec8355) with main (ab73dcf)

Open in CodSpeed

Footnotes

  1. 11 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

coderabbitai[bot]
coderabbitai bot reviewed Mar 9, 2026
View reviewed changes
Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
schema-engine/sql-schema-describer/tests/describers/postgres_describer_tests.rs (1)

2606-3015: ⚠️ Potential issue | 🟠 Major

Regenerate this entire snapshot instead of patching one field.

stripped_partial_indexes is not the only mismatch here. This expectation is still on the old SqlSchema debug shape (columns, inline default, missing current table/default/check/view fields), so adding one line will not make multiple_schemas_are_described() pass if the test runs.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 3e5a15d0-29e4-438d-97e2-a3404235f2c9

📥 Commits

Reviewing files that changed from the base of the PR and between ab73dcf and 6ec8355.

📒 Files selected for processing (4)
  • query-engine/connector-test-kit-rs/query-engine-tests/tests/queries/data_types/native/mysql.rs
  • query-engine/connector-test-kit-rs/query-engine-tests/tests/writes/data_types/native_types/mysql.rs
  • schema-engine/sql-schema-describer/tests/describers/mysql_describer_tests.rs
  • schema-engine/sql-schema-describer/tests/describers/postgres_describer_tests.rs

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 9, 2026

Wasm Query Compiler File Size

Engine This PR Base branch Diff
Postgres 3.505MiB 3.505MiB 0.000B
Postgres (gzip) 1.142MiB 1.142MiB 0.000B
Postgres (size-optimized) 1.766MiB 1.766MiB 0.000B
Postgres (size-optimized, gzip) 694.996KiB 694.906KiB 92.000B
Mysql 3.458MiB 3.458MiB 0.000B
Mysql (gzip) 1.127MiB 1.127MiB 0.000B
Mysql (size-optimized) 1.736MiB 1.736MiB 0.000B
Mysql (size-optimized, gzip) 684.225KiB 684.228KiB -3.000B
Sqlite 3.376MiB 3.376MiB 0.000B
Sqlite (gzip) 1.098MiB 1.098MiB -3.000B
Sqlite (size-optimized) 1.692MiB 1.692MiB 0.000B
Sqlite (size-optimized, gzip) 667.292KiB 667.291KiB 2.000B
SQL Server 3.598MiB 3.598MiB 0.000B
SQL Server (gzip) 1.162MiB 1.162MiB -1.000B
SQL Server (size-optimized) 1.766MiB 1.766MiB 0.000B
SQL Server (size-optimized, gzip) 698.659KiB 698.659KiB 0.000B
CockroachDB 3.555MiB 3.555MiB 0.000B
CockroachDB (gzip) 1.160MiB 1.160MiB 2.000B
CockroachDB (size-optimized) 1.791MiB 1.791MiB 0.000B
CockroachDB (size-optimized, gzip) 705.223KiB 705.231KiB -8.000B

@jacek-prisma jacek-prisma merged commit d684c19 into main Mar 11, 2026
112 of 113 checks passed
@jacek-prisma jacek-prisma deleted the test/fix-mysql-test-issues branch March 11, 2026 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@aqrln aqrln aqrln approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jacek-prisma @aqrln