Conversation
Passing trace id is required to handle tracing information. This is a temporary solution and it will be resolved when logging is improved.
This will complete (from the Rust side) #10004
dpetrick
approved these changes
Jan 14, 2022
- Make cargo check happy - Make @dom happy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current tracing implementation in the Node API conflicts with the OpenTelemetry collector layer, this makes really difficult to collect tracing information for technical reasons (explanation is a little long, ask me if you want more details).
This is (hopefully) a temporary solution for prisma/prisma#10004 and is required for prisma/prisma#10310 until we have more time to reconstruct the logging support for the QE in the Node API, right now we just pass whatever we get from the client to the database as a database comment, for example:
would generate a SQL command like this one: