Skip to content

User-facing errors for connection string problems#1427

Merged
pimeys merged 1 commit intomasterfrom
user-facing-error-for-uri-parsing
Dec 7, 2020
Merged

User-facing errors for connection string problems#1427
pimeys merged 1 commit intomasterfrom
user-facing-error-for-uri-parsing

Conversation

@pimeys
Copy link
Contributor

@pimeys pimeys commented Dec 2, 2020

Closes: #1241

Should also merge prisma/quaint#227 before merging this.

@pimeys pimeys added this to the 2.13.0 milestone Dec 2, 2020
@pimeys
Copy link
Contributor Author

pimeys commented Dec 2, 2020

Error printed:

The provided database string is invalid. Error parsing connection string: invalid port number in mysql://root:password-with-#@localhost:3306/mydb. Please refer to the documentation in https://www.prisma.io/docs/reference/database-reference/connection-urls for constructing a correct connection string. In some cases, certain characters must be escaped. Please check the string for any illegal characters.

@pimeys pimeys force-pushed the user-facing-error-for-uri-parsing branch 3 times, most recently from 27b1c75 to eadfd7a Compare December 7, 2020 10:34
Copy link
Contributor

@tomhoule tomhoule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@pimeys pimeys force-pushed the user-facing-error-for-uri-parsing branch from eadfd7a to b0c824e Compare December 7, 2020 10:51
@pimeys pimeys merged commit fce497a into master Dec 7, 2020
@pimeys pimeys deleted the user-facing-error-for-uri-parsing branch December 7, 2020 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Return a user-facing error for database URL parsing errors.

2 participants